Closed jakkdl closed 1 year ago
huh, test failures looks like it's an issue with the CI?
huh, test failures looks like it's an issue with the CI?
nvm, the warning was unrelated. But I'd forgotten to push the test file :upside_down_face:
Should be pretty much done now, other than what to do with the function signature on __aenter__
👀 looks like flake8 6.0.0 just came out with a new required argument in some logic we use for tests... fixing now.
Looks good :rocket:
Found two bugs with it right away 💪
Also looks like chasing down some similar patterns will result in follow-ups, so expect more issues next week 😅
Awesome!
Haha, wonderful :grin:
Follow up PR please?
The other thing it could cover is the idiom of using [functools]partial()
to pass keyword arguments through - it'd be great to check nursery.start_soon(partial(trio.run_process, cmd, shell=True))
by "seeing through" the call to partial.
Will do :+1:
Fixes #57
Quick and dirty:
start_soon
is called on is called "nursery"?with
?