was a bit tricky to get argparse to play along as I wanted, but all should now be fully working there.
test_113_options and test_114_options are actually broken on main if they're run on their own, since they didn't run parse_options to populate the namespace. I haven't fully figured out why it works when they run after other tests, presumably some object is shared which might be worth fixing to avoid future/other issues. But they now parse their args.
the behavior of 113 is maybe a bit weird, look through the test cases (particularly the ones added) to see if you find any cases that you think should/shouldn't be an error. is_startable is pretty easy to modify.
I don't love having to deal with two lists of calls, might merge them somewhere - but not a big deal.
sync_errors in test_flake8_trio has not been updated in a while, I think that should probably be a list of errors to ignore on sync code rather than the other way so you don't forget to expand the list.
Should otherwise be finished, maybe the error message on a bad parameter could be more helpful.
fixes #72
test_113_options
andtest_114_options
are actually broken on main if they're run on their own, since they didn't runparse_options
to populate the namespace. I haven't fully figured out why it works when they run after other tests, presumably some object is shared which might be worth fixing to avoid future/other issues. But they now parse their args.is_startable
is pretty easy to modify.sync_errors
in test_flake8_trio has not been updated in a while, I think that should probably be a list of errors to ignore on sync code rather than the other way so you don't forget to expand the list.Should otherwise be finished, maybe the error message on a bad parameter could be more helpful.