Closed jakkdl closed 1 year ago
Sounds good to me; mark ready-to-review when... you know... and I'll be happy to merge.
I added https://pre-commit.ci/ to my fork, and it now passes on my mirror PR over there: https://github.com/jakkdl/flake8-trio/pull/1
The largest issue was that pyright requires internet connectivity to run, which the pre-commit ci does not support
There's a couple options to get around that:
pre-commit run pyright --all-files
. This environment is not included in the default envlist.
--strict
(but most of those are function signatures not having -> None
which pyright doesn't require so it's been inconsistently applied)Various other considerations for this, or future PR's, or never:
# noqa
's (I've hacked together some ugly aliases that mostly solves this locally)autofix_prs
? I haven't used pre-commit ci enough to know how handy vs irritating vs dangerous it is, but noticed that flake8-bugbear has it disabled.But otherwise I think this should be good for merging
rebased on top of main
Renamed the check
ci action to show that it's now solely for type-checking. I tried doing that previously but failed, but idk what I did different that time.
It bit me a bunch of times that I didn't run tox before pushing minor changes, and
tox -e check
takes 13s on my system, so I've gradually recreated all the functionality from it in pre-commit + some other checks. So at this point it might be worth removingtox -e check
entirely and transitioning the CI to use pre-commit as well. If you approve of the idea I'll implement the necessary gh CI changes as well & clean uptox.ini
.(though it currently won't pass until #87 is merged)TODO: