python-trio / purerpc

Native, async Python gRPC client and server implementation supporting asyncio, uvloop, and trio
Apache License 2.0
217 stars 15 forks source link

Remove hyper-h2 patches #38

Closed VincentVanlaer closed 1 year ago

VincentVanlaer commented 1 year ago

These patches have been upstreamed in python-hyper/h2@fa8a6346 and python-hyper/h2@96aaef14 and have been released as part of h2 version 3.1.1.

belm0 commented 1 year ago

(and no one is complaining about h2 v4.x support, which is another signal that purerpc has few users)

belm0 commented 1 year ago

I'm not sure why CI isn't running-- I expect it to run on PR's, even for authors outside of python-trio org.

~Oh, this repo is on travis-ci.org, so it has to migrate to .com, or port to github actions.~

belm0 commented 1 year ago

Oh, this repo is on travis-ci.org, so it has to migrate to .com, or port to github actions.

actually, I had already ported to Actions 🤔

https://github.com/python-trio/purerpc/commit/62196dc659008d2c17bfa6d6f46022eeae796100

belm0 commented 1 year ago

I really don't know why CI isn't running:

workflow permissions setting: Screen Shot 2023-02-17 at 9 03 25 AM

workflow approval instructions: Screen Shot 2023-02-17 at 9 05 57 AM

belm0 commented 1 year ago

https://github.com/python-trio/purerpc/blob/9e96b7d6d5436d4b196c1cece208f907fee9c3a9/.github/workflows/ci.yml#L3

maybe should be on: [ pull_request ]