dictConfig in misc/greeter is excessive

python-trio / purerpc

Native, async Python gRPC client and server implementation supporting asyncio, uvloop, and trio

Apache License 2.0

217 stars 15 forks source link

dictConfig in misc/greeter is excessive #9

Open ei-grad opened 5 years ago

ei-grad commented 5 years ago

It doesn't make sense to have the copy-pasted verbose logging configuration in main.py, main_pingpong.py and main_pingpong_servicer.py, which has the effect equal to

logging.basicConfig(format="[%(asctime)s - %(name)s - %(levelname)s]:  %(message)s", level=logging.WARNING)

standy66 commented 5 years ago

I was kinda in a hurry when I did that, and just copy-pasted some leftover code from previous projects. Feel free to contribute.