search

python-trio / trimeter

(not ready yet) A simple but powerful job scheduler for Trio programs
https://trimeter.readthedocs.io
Other
63 stars 3 forks source link

Fix dereference to unbound variable in run_on_each() #13

Closed dahlia closed 5 years ago

dahlia commented 5 years ago

(See also: https://gitter.im/python-trio/general?at=5c4222becb47ec300064e070.)

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@4f21d83). Click here to learn what that means. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #13   +/-   ##
=========================================
  Coverage          ?   66.29%           
=========================================
  Files             ?        5           
  Lines             ?      178           
  Branches          ?       28           
=========================================
  Hits              ?      118           
  Misses            ?       46           
  Partials          ?       14
Impacted Files Coverage Δ
trimeter/_impl.py 60.68% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4f21d83...84374d1. Read the comment docs.

njsmith commented 5 years ago

thanks!

It's funny, 99% of the time when people submit their first PR they forget about the newsfragment and I have to nag them to add it. But you are like, too much on top of things – you included it, and now I have to remove it because trimeter is in the very special situation where it has on releases yet. So the next release notes will just be "initial release". No point in documenting the changes since the previous release when there is no previous release :-)

Also, I guess if you knew about the newsfragment thing then you've already read our contributing docs? Then you won't be surprised that I'm sending you a github invite now :-).