search

python-trio / trio-asyncio

a re-implementation of the asyncio mainloop on top of Trio
Other
187 stars 37 forks source link

Pass loop argument to Future() #113

Closed smurfix closed 7 months ago

smurfix commented 2 years ago

Fixes DeprecationWarning in Py3.10 Closes #112

codecov[bot] commented 2 years ago

Codecov Report

Merging #113 (fc15581) into master (308dd76) will decrease coverage by 51.95%. The diff coverage is n/a.

:exclamation: Current head fc15581 differs from pull request most recent head e82af14. Consider uploading reports for the commit e82af14 to get more accurate results

@@             Coverage Diff             @@
##           master     #113       +/-   ##
===========================================
- Coverage   82.23%   30.27%   -51.96%     
===========================================
  Files          11       11               
  Lines        1199     1199               
  Branches      175      193       +18     
===========================================
- Hits          986      363      -623     
- Misses        151      832      +681     
+ Partials       62        4       -58
Impacted Files Coverage Δ
trio_asyncio/_handles.py 24.05% <0.00%> (-70.89%) :arrow_down:
trio_asyncio/_deprecate.py 34.72% <0.00%> (-65.28%) :arrow_down:
trio_asyncio/_util.py 29.54% <0.00%> (-59.10%) :arrow_down:
trio_asyncio/_base.py 25.93% <0.00%> (-58.22%) :arrow_down:
trio_asyncio/_async.py 23.52% <0.00%> (-55.89%) :arrow_down:
trio_asyncio/_adapter.py 29.91% <0.00%> (-51.29%) :arrow_down:
trio_asyncio/_sync.py 19.84% <0.00%> (-51.15%) :arrow_down:
trio_asyncio/_loop.py 38.31% <0.00%> (-41.59%) :arrow_down:
trio_asyncio/_child.py 35.64% <0.00%> (-30.70%) :arrow_down:
oremanj commented 7 months ago

This is not necessary on newer versions of 3.10; there was a backport in December 2022 of a fix that only raises the warning if get_event_loop() actually creates a new loop. GIven that, and the general barely-limping-along status of trio-asyncio, I'm inclined to close this.