Closed oremanj closed 11 months ago
bump!
Is there anything preventing this being merged?
Is there anything preventing this being merged?
Just the fact that no one has approved it.
Since @agronholm has reviewed I'll let him approve if he's not too busy...
I may be a little out of my depth here but I'll see if I can give this a proper review over the weekend.
Code changes:
open_loop()
when using an async loop, instead of just claiming to. Raising them out ofdefault_exception_handler
doesn't work because asyncio catches it. Instead we now create a new task in the loop nursery to raise the exception.add_reader
oradd_writer
on a socket object (rather than fd) could produce an uncaught exception if the reader/writer were unregistered and the socket closed inside the same reader/writer callback.asyncio.current_task
on 3.12+ so that it looks at the current_loop contextvar instead of just the C-level running loop cache. This is now necessary becausecurrent_task
is now implemented in C and thus bypasses our monkeypatches by default.Test changes:
Closes #119, #120.