Setup dependency on pytest-runner makes installation hard in the walled environments

python-trio / trio-asyncio

a re-implementation of the asyncio mainloop on top of Trio

Other

188 stars 37 forks source link

Setup dependency on pytest-runner makes installation hard in the walled environments #47

Closed nonsleepr closed 5 years ago

nonsleepr commented 5 years ago

setup.py specifies setup_requires=['pytest-runner'] which, if not present, would be installed using EasyInstall which wouldn't respect any pip options, like custom index URLs. As a workaround, pytest-runner documentation suggests using conditional dependency. Alternatively, that dependency could be completely eliminated (make test runs pytest anyway).

njsmith commented 5 years ago

I'd be fine with dropping this... setup.py test is a neat idea that never really took off. And all the other python-trio projects recommend calling pytest directly anyway. @smurfix I think you set this up – any opinion?

nonsleepr commented 5 years ago

I'd suggest switching to tox to cover different versions of python (any maybe trio too). Drafted it in #48.

smurfix commented 5 years ago

Merged.