search

python-trio / trio-asyncio

a re-implementation of the asyncio mainloop on top of Trio
Other
188 stars 37 forks source link

open_cancel_scope → CancelScope #53

Closed smurfix closed 5 years ago

njsmith commented 5 years ago

Also you seem to have universal test failure due to warnings about open_cancel_scope being deprecated... did you miss some?

smurfix commented 5 years ago

Nope. Some other code still uses them. I assume that it's pytest-trio's fault, as it hasn't seen a release lately.

pquentin commented 5 years ago

Let's see if the pytest-trio release helps.

pquentin commented 5 years ago

The failing tests use pytest-trio 0.5.1 instead of 0.5.2: I don't know why.

smurfix commented 5 years ago

@pquentin because 0.5.2 wasn't released when they ran. Or the pypi results were cached.

njsmith commented 5 years ago

@smurfix I think you just merged with the wrong trio versions everywhere?