python-trio / trio-websocket

WebSocket client and server implementation for Python Trio
MIT License
70 stars 26 forks source link

Fix some deprecations in tests + remove some dependencies #143

Closed bluetech closed 3 years ago

bluetech commented 3 years ago

The first two commits fix some deprecations; since they are only in the tests I didn't bother with backward compatibility with older trio/attrs versions.

The next commits remove the ipaddress, wsaccel and yarl dependencies, please see the commit messages for details.

Once Python 3.5 is dropped can also remove the async_generator dep I think, which will leave only trio and wsproto.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 125


Changes Missing Coverage Covered Lines Changed/Added Lines %
trio_websocket/_impl.py 13 15 86.67%
<!-- Total: 13 15 86.67% -->
Files with Coverage Reduction New Missed Lines %
trio_websocket/_impl.py 1 91.99%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 122: -0.1%
Covered Lines: 474
Relevant Lines: 496

💛 - Coveralls
belm0 commented 3 years ago

pypy build is failing

https://travis-ci.com/github/HyperionGray/trio-websocket/jobs/434094535

bluetech commented 3 years ago

pypy build is failing

This seems unrelated, something about cryptography and openssl. Probably upgrading the CI image or downgrading cryptography should fix it.

bluetech commented 3 years ago

Thanks for the review @belm0, updated.