python-trio / trio-websocket

WebSocket client and server implementation for Python Trio
MIT License
70 stars 26 forks source link

Fix a hang when the remote hangs up rudely #182

Closed orausch closed 1 year ago

orausch commented 1 year ago

Bad ordering:

  1. Remote close
  2. TCP closed
  3. Local confirms => no ConnectionClosed raised, client hangs forever
belm0 commented 1 year ago

Checked autobahn suite, seems OK.

thank you

trio-bot[bot] commented 1 year ago

Hey @orausch, it looks like that was the first time we merged one of your PRs! Thanks so much! :tada: :birthday:

If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:

If you want to read more, here's the relevant section in our contributing guide.

Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you.

If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out!