search

python-trio / trio-websocket

WebSocket client and server implementation for Python Trio
MIT License
70 stars 26 forks source link

Revisit optional nursery #35

Closed mehaase closed 6 years ago

mehaase commented 6 years ago

This PR implements #31.

njsmith commented 6 years ago

Defaulting to use_ssl=True is probably plausible these days too.

On Tue, Oct 2, 2018 at 7:15 AM, Mark E. Haase notifications@github.com wrote:

@mehaase commented on this pull request.

In trio_websocket/init.py https://github.com/HyperionGray/trio-websocket/pull/35#discussion_r221968317 :

@@ -22,21 +22,46 @@

@asynccontextmanager @async_generator -async def open_websocket(host, port, resource, use_ssl, nursery=None): +async def open_websocket(host, port, resource, use_ssl):

I'm a security nerd, so I made the unusual/controversial decision to require the SSL argument. This forces the user to at least think about whether to use SSL or not.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/HyperionGray/trio-websocket/pull/35#discussion_r221968317, or mute the thread https://github.com/notifications/unsubscribe-auth/AAlOaGgR4LfmO9T5AHNXsDj9JPDUcTd6ks5ug3UVgaJpZM4XC3B8 .

-- Nathaniel J. Smith -- https://vorpus.org http://vorpus.org