BrokenStreamError deprecation

python-trio / trio-websocket

WebSocket client and server implementation for Python Trio

MIT License

70 stars 26 forks source link

BrokenStreamError deprecation #39

Closed belm0 closed 6 years ago

belm0 commented 6 years ago

I'm not sure what's to be done.

Having trio-websocket require > Trio 0.8.0 just for this?
Stay on BrokenStreamError and let users live with the deprecation warning spam?
Select the exception type at runtime based on Trio version?

/.../site-packages/trio_websocket/__init__.py:210: TrioDeprecationWarning: trio.BrokenStreamError is deprecated since Trio 0.8.0; use trio.BrokenResourceError instead (https://github.com/python-trio/trio/issues/620)

mehaase commented 6 years ago

Thanks for the heads up! I haven't even started integrating trio-websocket into my own application, so I think you are the only real user right now. I am okay with requring Trio > 0.8.0 if you are.

belm0 commented 6 years ago

SGTM