python-trio / trio-websocket

WebSocket client and server implementation for Python Trio
MIT License
70 stars 26 forks source link

Upgrade to trio channels (fixes #41) #67

Closed mehaase closed 6 years ago

mehaase commented 6 years ago

Upgrade to Trio 0.9 and use the official channels API. Remove the prototype channels code that was checked into this repo. Copy the new, channel-based MemoryListener from trio into our test suite.

The only surprise here is that closing a channel is now async, so this changes _close_web_socket and _abort_web_socket from sync to async functions.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 50


Changes Missing Coverage Covered Lines Changed/Added Lines %
trio_websocket/init.py 12 14 85.71%
<!-- Total: 12 14 85.71% -->
Totals Coverage Status
Change from base Build 48: 8.06%
Covered Lines: 339
Relevant Lines: 370

💛 - Coveralls
coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 50


Changes Missing Coverage Covered Lines Changed/Added Lines %
trio_websocket/init.py 12 14 85.71%
<!-- Total: 12 14 85.71% -->
Totals Coverage Status
Change from base Build 48: 8.06%
Covered Lines: 339
Relevant Lines: 370

💛 - Coveralls