refactor WebsocketConnection received data handling: - Githubissues

python-trio / trio-websocket

WebSocket client and server implementation for Python Trio

MIT License

70 stars 26 forks source link

refactor WebsocketConnection received data handling: #80

Closed belm0 closed 6 years ago

belm0 commented 6 years ago

combine BytesReceived and TextReceived handlers
use join to build message rather than +=

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 76

8 of 10 (80.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.8%) to 91.892%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
trio_websocket/_impl.py	8	10	80.0%
<!--	Total:	8	10	80.0%	-->

Totals
Change from base Build 71:	0.8%
Covered Lines:	340
Relevant Lines:	370

💛 - Coveralls

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 77

7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.3%) to 92.371%

Totals
Change from base Build 71:	1.3%
Covered Lines:	339
Relevant Lines:	367

💛 - Coveralls

mehaase commented 6 years ago

I just merged this into delay_connection_closed branch (PR #79).