coveralls
commented
6 years ago Pull Request Test Coverage Report for Build 103
- 28 of 28 (100.0%) changed or added relevant lines in 1 file are covered.
- 1 unchanged line in 1 file lost coverage.
- Overall coverage increased (+0.3%) to 92.822%
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| trio_websocket/_impl.py | 1 | 93.03% | ||
| <!-- | Total: | 1 | --> |
| Totals | |
|---|---|
| Change from base Build 97: | 0.3% |
| Covered Lines: | 375 |
| Relevant Lines: | 404 |
mehaase
Add arguments for configuring message queue size and maximum message size.
The closing code is needlessly complex and made the message size code very difficult to write, so I opened up #90 to refactor the way that closing is handled.
The only other thing that stands out to me is that the connection APIs have a lot of repeated arguments now. I know I could use
**kwargsto make this more DRY, but then I think (?) that the docs would show kwargs instead of the actual argument names, and that doesn't seem very user-friendly. Thoughts?