python-trio / trio

Trio – a friendly Python library for async concurrency and I/O
https://trio.readthedocs.io
Other
6.01k stars 325 forks source link

CI changes #2885

Open A5rocks opened 7 months ago

A5rocks commented 7 months ago

Fixing existing runs:

Adding more runs:

Removing runs:

These feel like they will take more motivation than I currently have :(

jakkdl commented 7 months ago

A more fun change: Add python 3.13

TeamSpen210 commented 7 months ago

We also aren't running 3.11/3.12 on Windows.

jakkdl commented 7 months ago

weird CI fail for macOS 3.8: https://github.com/python-trio/trio/actions/runs/7232062095/job/19705878765?pr=2891

jakkdl commented 6 months ago

Add back Alpine Linux for testing musl libc. https://github.com/python-trio/trio/pull/2917

jakkdl commented 6 months ago

Sleep timing fail on MacOS pypy3.10 https://github.com/python-trio/trio/actions/runs/7448486091/job/20262980216?pr=2886

FAILED ../../../_temp/116e3acf-3f1d-45b1-afa8-48d74a477716/pypy-c-jit-184208-0c87577e022f-macos_x86_64/lib/pypy3.10/site-packages/trio/_tests/test_timeouts.py::test_sleep - assert (1.70860500699996 / 1.0) < 1.5

Not especially weird, and only problematic if it's encountered regularly.

jakkdl commented 5 months ago

Is it possible to trigger actions on "push or pull request" rather than "push and pull request"? I started #2942 on a branch in trio/ to be able to run tests w/o spamming a PR, but once I opened the PR I'm getting double runs.

TeamSpen210 commented 5 months ago

A few possible ways:

A5rocks commented 5 months ago

I think the 3rd is the best solution. Just a gh pr view on push and if there's a PR then don't run the next steps. Maybe a if: in the actual CI workflows that checks input and otherwise skips?

The 1st isn't great cause it'll clutter notifications too

jakkdl commented 5 months ago

Edited list in OP to refer to #2776 and #2678 wrt to pypy+windows (and split up mac&windows at the same time)

jakkdl commented 1 month ago

A more fun change: Add python 3.13

with a first beta released this should probably be done sooner rather than later.