Closed A5rocks closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.63%. Comparing base (
71457f7
) to head (4bd7afa
).
cc @jeongilpark could you see if this works for you? I'm not sure if you're actually ending up using trio. (if you do, maybe we should do a better solution, like... I don't know, maybe use gevent.monkey.get_original
? or... idk this level of trio very well.)
@jakkdl @CoolCat467 - is this issue and the one specifically listed below resolved now?
@jakkdl @CoolCat467 - is this issue and the one specifically listed below resolved now?
no? I don't see any reason why they've would've been fixed with no changes to any code.
Might be a good idea to add a comment as to why we're using a lambda here. Otherwise someone coming along in the future might "optimise" that out, especially since I know PyLint and therefore Ruff has a rule which would flag this.
This seems to work:
Fixes: https://github.com/python-trio/trio/issues/2848
... While trio still doesn't work under gevent, I think not erroring when importing is a good property to have.