Closed jakkdl closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
7cb15ea
) 99.64% compared to head (03fee26
) 99.64%.
sounds like we're settling on internalerror, and leaving any eventual warning for #1600 or similar. removed the comment and expanded the error message to make it clearer for the user that it might be their fault.
Very nice! Merging now 😁
In preparation for eventual deprecation of
strict_exception_groups=False
(https://github.com/jakkdl/trio/tree/deprecate_exceptiongroups_false) we probably shouldn't rely on it ourselves in the internal code.2611 - the original issue where errors raised before
task_status.started()
got double-wrapped1599 - for why the old nursery can have multiple tasks.
2844 - the regression error that occured after my initial fix for #2611 in #2826
Fairly straightforward implementation, other than perhaps exactly what to raise when multiple exceptions do occur. The main code that tests this is
test_trio_run_strict_before_started
, I added the new test after it only to trigger the case where multiple exceptions do pop up in the old nursery.