search

python-trio / trio

Trio – a friendly Python library for async concurrency and I/O
https://trio.readthedocs.io
Other
5.98k stars 325 forks source link

Make sure we're running on M1 MacOS #2953

Closed A5rocks closed 2 months ago

A5rocks commented 4 months ago

macos-latest doesn't seem to include macos-14: https://github.com/python-trio/trio/actions/runs/7865413592/job/21458313729#step:1:8

So this should make things run on M1 macs.

Reference: https://github.com/python-trio/trio/issues/2885

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.89%. Comparing base (b4c19bc) to head (811d289).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2953 +/- ## =========================================== - Coverage 99.63% 80.89% -18.74% =========================================== Files 117 117 Lines 17602 17557 -45 Branches 3174 1398 -1776 =========================================== - Hits 17537 14202 -3335 - Misses 46 3250 +3204 - Partials 19 105 +86 ``` [see 64 files with indirect coverage changes](https://app.codecov.io/gh/python-trio/trio/pull/2953/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-trio)
A5rocks commented 4 months ago

Oh despite 3.8 and 3.9 having installers that work on arm, it looks like setup-python doesn't recognize that yet: https://github.com/actions/setup-python/issues/808

From the issue it sounds like all that's missing is someone needs to build for 3.8 and 3.9 arm64? So I'm comfortable letting this sit until that happens.

A5rocks commented 2 months ago

This should be unblocked now

A5rocks commented 2 months ago

Actually this is no longer necessary

macos-latest will now be M1 macos