search

python-trio / trio

Trio – a friendly Python library for async concurrency and I/O
https://trio.readthedocs.io
Other
5.98k stars 325 forks source link

Bump dependencies from commit 9a1964 #2978

Closed github-actions[bot] closed 3 months ago

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.64%. Comparing base (9a1964f) to head (d70e505). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2978 +/- ## ======================================= Coverage 99.64% 99.64% ======================================= Files 117 117 Lines 17594 17594 Branches 3171 3171 ======================================= Hits 17532 17532 Misses 43 43 Partials 19 19 ``` | [Files](https://app.codecov.io/gh/python-trio/trio/pull/2978?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-trio) | Coverage Δ | | |---|---|---| | [src/trio/\_socket.py](https://app.codecov.io/gh/python-trio/trio/pull/2978?src=pr&el=tree&filepath=src%2Ftrio%2F_socket.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-trio#diff-c3JjL3RyaW8vX3NvY2tldC5weQ==) | `100.00% <100.00%> (ø)` | |
TeamSpen210 commented 3 months ago

Hmm, those imports succeed on Linux, but fail on Mac/Windows. It'll need to use a # type: ignore[attr-defined, unused-ignore] comment to allow all those cases, or ideally figure out how to tell Mypy those lines won't run on non-Linux platforms. The if statement should be doing that, not sure why it isn't.