Closed github-actions[bot] closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.63%. Comparing base (
93933b5
) to head (74401a4
).
I just realized that our pre-commit autoupdates are kinda unnecessary. Should we disable those (if we can) and then maybe make this biweekly?
Apparently can't disable pre-commit autoupdates (not seeing anything on their website), but we could change autoupdate_schedule
to monthly
or quarterly
instead of weekly
. Maybe while we are at it we could trial enabling autofix_prs
?
I still don't really think autofix_prs
would work well tbh. Also monthly
probably sounds fine, I'm super surprised we can't disable autoupdates though. Maybe it's a setting in the CI? Nevermind, checked the site and I cannot.
(though my opinion on autofix_prs
is very weakly held)
We could probably use https://pre-commit.ci/lite which might be slightly slower but a) uses github actions and b) simply cannot autoupdate. (it supposedly can still autofix though so that's a thing) What do you think?
I think they want things to be auto-updated because if you think about it from their perspective, if you have tons of projects using similar tools, suggesting for everyone to update to new versions means they can purge old copies and save disk space. And really most of the main reasons for using pre-commit.ci in the first place is keeping everything up to date and the PR autofixing.
I don't see much of a point to using the lite version, as what it seems to be intended to replicate is the autofix part. Auto updating is as simple as running pre-commit autoupdate
, which is a part of autodeps already.
I personally like pre-commit's auto update PRs because it means all the hooks stay more up to date. If we had to get rid of it for some reason though, autodeps running more often would accomplish the same thing.
I personally like pre-commit's auto update PRs because it means all the hooks stay more up to date. If we had to get rid of it for some reason though, autodeps running more often would accomplish the same thing.
oh yeah, that's what I meant. I'd personally like to consolidate autodeps and the pre-commit.ci prs (by removing the pre-commit.ci prs and making autodeps biweekly, or maybe weekly? probably biweekly).
There are pros and cons to merging the two in my eyes.
Pros:
Cons:
yep the PR autofixing was why I was pointing out the lite version. the way I see it, the versions being different is annoying and neither of the cons is something we care about as much.
I just realized that our pre-commit autoupdates are kinda unnecessary. Should we disable those (if we can) and then maybe make this biweekly?