Closed jakkdl closed 6 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.63%. Comparing base (
a7db0e4
) to head (945a3b5
).
Looks good to me!
Should we consider moving over some of the trio-typing test suite, since apparently that catches some issues that the trio tests don't?
There's not much that's worth adapting, I don't think we want to adapt their method of running internal mypy functions, so it would consist of copying and adapting the test-data. But we already cover most everything:
trio.Path
and TaskStatus
The only things left were run
, that trio-typing
raised a typing error if you tried to instantiate Cancelled
, Nursery.start
, and some trivial stuff that would raise typechecking errors when we run mypy on our test suite.
I noticed this when going through the trio-typing test suite. I don't see any reason why this would've been intentionally skipped in #2881, so I suspect it just got missed?