Closed ioistired closed 5 years ago
Merging #3 into master will decrease coverage by
5.3%
. The diff coverage is52.38%
.
@@ Coverage Diff @@
## master #3 +/- ##
=========================================
- Coverage 92.8% 87.5% -5.31%
=========================================
Files 6 6
Lines 139 160 +21
Branches 3 4 +1
=========================================
+ Hits 129 140 +11
- Misses 7 17 +10
Partials 3 3
Impacted Files | Coverage Δ | |
---|---|---|
triopg/_tests/test_triopg.py | 97.05% <100%> (+0.63%) |
:arrow_up: |
triopg/_triopg.py | 83.14% <33.33%> (-10.1%) |
:arrow_down: |
@touilleMan are you still using/maintaining this?
I would be willing to take it over, if not.
@njsmith I'm still using this library
@bmintz every help is welcomed ! if @njsmith is ok we can add you to the trio organization 😃
@touilleMan Cool! Just wanted to check b/c I wasn't sure what was going on :-).
And re: inviting @bmintz: Just merge the PR, and that will trigger the invitation :-)
@bmintz Sorry, my attention is pretty taken up right now by trio proper and HTTP client stuff, so I can't really review this properly myself. But I don't want to leave you hanging, and @touilleMan said lgtm, so I guess I'll hit the merge button :-). Once its merged, our bot should automatically send you an invitation to join the org. And maybe you and @touilleMan can work out between yourselves how you want to handle your other PR, and future PRs?
Hey @bmintz, it looks like that was the first time we merged one of your PRs! Thanks so much! :tada: :birthday:
If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:
Github will automatically subscribe you to notifications on all our repositories. (But you can unsubscribe again if you don't want the spam.)
You'll be able to help us manage issues (add labels, close them, etc.)
You'll be able to review and merge other people's pull requests
You'll get a [member] badge next to your name when participating in the Trio repos, and you'll have the option of adding your name to our member's page and putting our icon on your Github profile (details)
If you want to read more, here's the relevant section in our contributing guide.
Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you.
If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out!
I'm really glad to see that this PR merged! it adds a lot of good quality-of-life improvements to triopg around connection pooling and running queries concurrently.
I see that the latest version appears to be triopg==0.3.0
, which does not have these changes included. Is there something I can do to help out with releasing a new version of this package?
@cpdean I've tagged v0.4.0, but I'll need someone else (likely @touilleMan) to upload to PyPI.
@iomintz I've done the v0.4.0 release 🎉
Implements #2