python-trio / triopg

PostgreSQL client for Trio based on asyncpg
Other
45 stars 8 forks source link

Add proxy for prepared statements #9

Closed serjflint closed 4 years ago

serjflint commented 4 years ago

Add proxy for prepared statements

codecov[bot] commented 4 years ago

Codecov Report

Merging #9 into master will increase coverage by 9.70%. The diff coverage is 98.29%.

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   87.50%   97.20%   +9.70%     
==========================================
  Files           6        6              
  Lines         160      250      +90     
  Branches        4       13       +9     
==========================================
+ Hits          140      243     +103     
+ Misses         17        3      -14     
- Partials        3        4       +1     
Impacted Files Coverage Δ
triopg/_triopg.py 94.73% <95.45%> (+11.59%) :arrow_up:
triopg/_tests/conftest.py 100.00% <100.00%> (+13.33%) :arrow_up:
triopg/_tests/test_triopg.py 100.00% <100.00%> (+2.94%) :arrow_up:
touilleMan commented 4 years ago

@serjflint thanks for the PR, I've updated it to add tests on it... and also support for cursor because why not ;-)

serjflint commented 4 years ago

and also support for cursor because why not ;-)

There is an issue on the tracker exactly asking for that. P.S.: I sent you a mail on the day I wrote the PR. Did you receive it? If not, can you contact me? my_nickname at gmail dot com

trio-bot[bot] commented 4 years ago

Hey @serjflint, it looks like that was the first time we merged one of your PRs! Thanks so much! :tada: :birthday:

If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:

If you want to read more, here's the relevant section in our contributing guide.

Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you.

If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out!