Closed serjflint closed 4 years ago
Merging #9 into master will increase coverage by
9.70%
. The diff coverage is98.29%
.
@@ Coverage Diff @@
## master #9 +/- ##
==========================================
+ Coverage 87.50% 97.20% +9.70%
==========================================
Files 6 6
Lines 160 250 +90
Branches 4 13 +9
==========================================
+ Hits 140 243 +103
+ Misses 17 3 -14
- Partials 3 4 +1
Impacted Files | Coverage Δ | |
---|---|---|
triopg/_triopg.py | 94.73% <95.45%> (+11.59%) |
:arrow_up: |
triopg/_tests/conftest.py | 100.00% <100.00%> (+13.33%) |
:arrow_up: |
triopg/_tests/test_triopg.py | 100.00% <100.00%> (+2.94%) |
:arrow_up: |
@serjflint thanks for the PR, I've updated it to add tests on it... and also support for cursor because why not ;-)
and also support for cursor because why not ;-)
There is an issue on the tracker exactly asking for that. P.S.: I sent you a mail on the day I wrote the PR. Did you receive it? If not, can you contact me? my_nickname at gmail dot com
Hey @serjflint, it looks like that was the first time we merged one of your PRs! Thanks so much! :tada: :birthday:
If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:
Github will automatically subscribe you to notifications on all our repositories. (But you can unsubscribe again if you don't want the spam.)
You'll be able to help us manage issues (add labels, close them, etc.)
You'll be able to review and merge other people's pull requests
You'll get a [member] badge next to your name when participating in the Trio repos, and you'll have the option of adding your name to our member's page and putting our icon on your Github profile (details)
If you want to read more, here's the relevant section in our contributing guide.
Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you.
If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out!
Add proxy for prepared statements