python-trio / unasync

The async transformation code.

Other

91 stars 13 forks source link

Added functionality to convert asynccontextmanager to contextmanager. #31

Closed RatanShreshtha closed 5 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #31 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #31   +/-   ##
=======================================
  Coverage   89.06%   89.06%           
=======================================
  Files           4        4           
  Lines         128      128           
  Branches       30       30           
=======================================
  Hits          114      114           
  Misses          6        6           
  Partials        8        8

Impacted Files	Coverage Δ
src/unasync/__init__.py	`88.88% <ø> (ø)`	:arrow_up:
unasync/__init__.py	`88.88% <0%> (ø)`	:arrow_up:

RatanShreshtha commented 5 years ago

Thanks @pquentin

pquentin commented 5 years ago

I've thought about this more and I'm not sure that we don't want to support async_generator. I'll continue to think about it and will continue to comment on this PR.

pquentin commented 5 years ago

I opened https://github.com/python-trio/unasync/issues/32 for the discussion about async_generator support. Now I can merge this PR. Thanks!