search

python-trio / unasync

The async transformation code.
Other
91 stars 13 forks source link

Support Python 2.7 #34

Closed pquentin closed 5 years ago

pquentin commented 5 years ago

Now that Python 2.7 support in python-trio/urllib3 could be a differentiating feature, I thought that I would see how hard Python 2.7 support could be in unasync. Turns out it was not that hard!

codecov[bot] commented 5 years ago

Codecov Report

Merging #34 into master will decrease coverage by 0.89%. The diff coverage is 94.28%.

@@            Coverage Diff            @@
##           master      #34     +/-   ##
=========================================
- Coverage   93.75%   92.85%   -0.9%     
=========================================
  Files           4        4             
  Lines         128      168     +40     
  Branches       30       40     +10     
=========================================
+ Hits          120      156     +36     
- Misses          2        4      +2     
- Partials        6        8      +2
Impacted Files Coverage Δ
src/unasync/__init__.py 92.77% <94.28%> (-0.88%) :arrow_down:
unasync/__init__.py 92.77% <0%> (-0.88%) :arrow_down:
pquentin commented 5 years ago

Hmm codecov now thinks that src/unasync/ and unasync/ are distinct paths when they're not.

RatanShreshtha commented 5 years ago

I am merging it now. Closes #28