search

python-trio / unasync

The async transformation code.
Other
91 stars 13 forks source link

Fix link to issues #44

Closed RatanShreshtha closed 5 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #44 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files           4        4           
  Lines         168      168           
  Branches       40       40           
=======================================
  Hits          162      162           
  Misses          2        2           
  Partials        4        4
pquentin commented 5 years ago

Okay so regarding the build failure, as you know it has nothing to do with your changes, our build just become broken since the last build that happened four months ago because of a new warning.

We can't fix this warning as it looks like the issue should be fixed by setuptools, possibly in https://github.com/pypa/setuptools/pull/1855. The pytest.ini change was probably correct, but you need to do this and to remove -W error because it looks like if we set -W error then the pytest.ini configuration is ignored, see https://docs.pytest.org/en/latest/warnings.html#deprecationwarning-and-pendingdeprecationwarning:

If warnings are configured at the interpreter level, using the PYTHONWARNINGS environment variable or the -W command-line option, pytest will not configure any filters by default.

Also pytest doesn’t follow PEP-0506 suggestion of resetting all warning filters because it might break test suites that configure warning filters themselves by calling warnings.simplefilter (see issue #2430 for an example of that).

pquentin commented 5 years ago

Thank you!

pquentin commented 5 years ago

I just stumbled upon it, the correct issue in setuptools is https://github.com/pypa/setuptools/issues/479, so that confirms they need to work on it.