python-trio / unasync

The async transformation code.
Other
91 stars 13 forks source link

Rename class names in type forward references #53

Closed florimondmanca closed 4 years ago

florimondmanca commented 4 years ago

Adds support for renaming type hints to async classes that use a forward reference, i.e. xyz: "AsyncXYZ".

(Support for renaming when the type hint is a regular name, i.e. xyz: AsyncXYZ, was already added via #49.)

codecov[bot] commented 4 years ago

Codecov Report

Merging #53 into master will increase coverage by 0.22%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   96.55%   96.77%   +0.22%     
==========================================
  Files           4        4              
  Lines         174      186      +12     
  Branches       44       46       +2     
==========================================
+ Hits          168      180      +12     
  Misses          2        2              
  Partials        4        4
Impacted Files Coverage Δ
src/unasync/__init__.py 96.73% <100%> (+0.22%) :arrow_up:
unasync/__init__.py 96.73% <0%> (+0.22%) :arrow_up:
trio-bot[bot] commented 4 years ago

Hey @florimondmanca, it looks like that was the first time we merged one of your PRs! Thanks so much! :tada: :birthday:

If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:

If you want to read more, here's the relevant section in our contributing guide.

Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you.

If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out!