Calling setup.py build from tests.

[RatanShreshtha]

I have added an async function in example_pkg and then I am trying to call setup.py build from tests. But I am not able to see folder _sync.

[RatanShreshtha]

Should we separate the tests folder from inside the asyncbleach folder sometimes it's really confusing?

Maybe something like that

...
- src/asyncbleach
- tests/
...

[pquentin]

It's certainly possible, but I think it's only a matter of preference, see https://docs.pytest.org/en/latest/goodpractices.html. Why do you think having tests in src/asyncbleach/_tests is confusing?

[RatanShreshtha]

I have created a new _async dir but still it is not running as expected

[pquentin]

Can you please share what you tried? I would be happy to take a look!

[pquentin]

@RatanShreshtha I've made some progress! pytest works locally. The main issue was "find_packages". I've looked at python-trio/urllib3 to find what the issue was.

However, the current test fails in Travis, I think the fix is to use a temporary directory instead of running python setup.py build on the committed example_pkg. But I'm not certain.

[codecov-io]

Codecov Report

Merging #6 into master will increase coverage by 5.79%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   66.27%   72.07%   +5.79%     
==========================================
  Files           3        3              
  Lines          86      111      +25     
  Branches       15       15              
==========================================
+ Hits           57       80      +23     
+ Misses         27       26       -1     
- Partials        2        5       +3

Impacted Files	Coverage Δ
asyncbleach/_tests/test_asyncbleach.py	60.97% <100%> (-14.03%)	:arrow_down:
asyncbleach/__init__.py	78.26% <0%> (+14.49%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e57ad5a...3f5c9a6. Read the comment docs.

[pquentin]

@RatanShreshtha make sure to pull from the master branch before starting your next pull request! I rebased some commits here. Thanks.

[pquentin]

And let's stop using "rebased-patch-1": let's use another branch name the next time, that describes what the pull request does. Here it could have been "test-setup-py", for example.