python-trio / unasync

The async transformation code.

Other

89 stars 13 forks source link

Replace tokenization with tokenize_rt #77

Closed pquentin closed 2 years ago

pquentin commented 2 years ago

The standard library module tokenize does not round trip, so we had to implement our own tokenization on top of it. However, tokenize_rt does it better and will enable #75, so let's adopt it instead.

codecov[bot] commented 2 years ago

Codecov Report

Merging #77 (ce69cb5) into master (0d21b04) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #77   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          110        93   -17     
  Branches        31        26    -5     
=========================================
- Hits           110        93   -17

Impacted Files	Coverage Δ
src/unasync/__init__.py	`100.00% <100.00%> (ø)`

pquentin commented 2 years ago

Thanks, I removed the pin! Also fixed Windows CI. Can you please take another look?

pquentin commented 2 years ago

@asottile Thank you for tokenize_rt! @sethmlarson Thank you for the reviews!