search

python-validators / validators

Python Data Validation for Humans™.
MIT License
977 stars 155 forks source link

add validator ETH addresses (ERC20) #276

Closed msamsami closed 1 year ago

msamsami commented 1 year ago

This is a validator for ERC20 Ethereum (ETC) addresses.

msamsami commented 1 year ago

@joe733 Please merge this PR first and merge #277 after that to avoid conflicts.

msamsami commented 1 year ago

@msamsami, please make this PR do one thing. Create another PR to move btc_adderess.py to validators/crypto_addresses.

@joe733 It's done. Here is the correct order for merging the PRs: #276 --> #277 --> #278

yozachar commented 1 year ago

Tests have failed. Ref: https://github.com/python-validators/validators/actions/runs/5387269990/jobs/9778426797?pr=276#step:6:182

Also, please use black to format code. Ref: https://github.com/python-validators/validators/actions/runs/5387269990/jobs/9778426797?pr=276#step:6:203

Instead if you simply run tox, all of this could be resolved, locally.

msamsami commented 1 year ago

@joe733 I added backend dependencies of eth-hash and reformatted code using black.

yozachar commented 1 year ago

@msamsami thanks for the PR!