search

python-validators / validators

Python Data Validation for Humans™.
MIT License
977 stars 155 forks source link

add validator TRX addresses (TRC20) #277

Closed msamsami closed 7 months ago

msamsami commented 1 year ago

This is a validator for TRC20 Tron (TRX) addresses.

yozachar commented 1 year ago

Hi @msamsami thanks for the PR.

Can you move both #276 & #277 to a folder crypto_addresses under validators, like so?

.
|---- validators
    |---- crypto_addresses
        |---- eth_address.py
        |---- trx_address.py

And do the same with their corresponding tests?

msamsami commented 1 year ago

Hi @joe733

Sure. I'll move btc_address.py and its test to the new directories as well.

msamsami commented 1 year ago

Hi @msamsami thanks for the PR.

Can you move both #276 & #277 to a folder crypto_addresses under validators, like so?

.
|---- validators
    |---- crypto_addresses
        |---- eth_address.py
        |---- trx_address.py

And do the same with their corresponding tests?

Hi @joe733

It's done. Please merge #276 first and then #277 to avoid any conflicts. The final structure would be like this:

.
|---- tests
    |---- crypto_addresses
        |---- __init__.py
        |---- test_btc_address.py
        |---- test_eth_address.py
        |---- test_trx_address.py

|---- validators
    |---- crypto_addresses
        |---- __init__.py
        |---- btc_address.py
        |---- eth_address.py
        |---- trx_address.py
yozachar commented 1 year ago

@msamsami please sync add-trx-validator branch from upstream.

yozachar commented 7 months ago

Ref: https://github.com/python-validators/validators/pull/278#issuecomment-2036013050