Closed hagenrd closed 4 months ago
Hey @hagenrd thanks! Do you mind reviewing: #367, before it's merged?
Thanks for the quick turnaround! Any chance you have some time to provide a patch that includes those changes?
Sorry, I meant patch in terms of a semantic version, i.e. a patch-release (0.28.1).
It appears that, currently, any character is valid for the final character in the gTLD if
rfc1034
isTrue
, for example:I believe the '.' just needs to be escaped in the pattern string (link):
Also, it appears question marks are allowed when
rfc_2782
isTrue
for domain validation:This appears to be from the use of '?' after the '_' inside of a character class:
Presumably, this is to make the '_' optional, but since metacharacters aren't active in character classes (link), this is interpreted as a literal '?' instead.