fix: return HTML from `render()`

python-visualization / branca

This library is a spinoff from folium, that would host the non-map-specific features.

https://python-visualization.github.io/branca/

MIT License

118 stars 66 forks source link

fix: return HTML from `render()` #106

Closed paulswartz closed 2 years ago

paulswartz commented 2 years ago

Follow-up ticket to python-visualization/folium#1459 to return the HTML from Element.render().

Conengmo commented 2 years ago

This is a bit tricky, since this adds .render() calls that weren't there before. That means we're potentially adding computations that are not necessary. This could be a significant burden if we're rendering many many elements.

Is there another way to get the output we need?
Or, can we make sure adding these renders is harmless?

To be continued.

Conengmo commented 2 years ago

Looking a bit more into it, I don't see this change working. Rendering the parent of MacroElement does nothing, it just outputs an empty template. I'll comment more in the PR on folium.