search

python-visualization / branca

This library is a spinoff from folium, that would host the non-map-specific features.
https://python-visualization.github.io/branca/
MIT License
111 stars 63 forks source link

Docs #121

Closed ocefpaf closed 1 year ago

ocefpaf commented 1 year ago

Publish docs using GitHub Actions instead of Travis-CI.

Conengmo commented 1 year ago

@ocefpaf could it be the Action that publishes the docs runs on all pull requests?

https://github.com/python-visualization/branca/actions/workflows/deploy-docs.yml

https://github.com/python-visualization/branca/blob/main/.github/workflows/deploy-docs.yml#L4

Conengmo commented 1 year ago

Same for the Pypi Action, do we need that on all commits? I know at the bottom there's a check, but still, maybe wasteful? https://github.com/python-visualization/branca/blob/main/.github/workflows/pypi.yml

ocefpaf commented 1 year ago

I don't think it is wasteful b/c both runs pretty quickly. They do help ensure the tarball and docs are not broken by code changes. If you feel strongly about it we can run only on deployment instead.

Conengmo commented 1 year ago

Alright, that sounds reasonable. Thanks for commenting on this :)

ocefpaf commented 1 year ago

BTW, if we do want to save resources, we can test Windows and macOS only for latest Python. That would reduce the testing matrix significantly and those OSes are usually the slower ones to spin up on GHA.

martinfleis commented 1 year ago

+1 on that.