search

python-visualization / branca

This library is a spinoff from folium, that would host the non-map-specific features.
https://python-visualization.github.io/branca/
MIT License
112 stars 64 forks source link

Remove _env instance attribute from Element #145

Closed Conengmo closed 10 months ago

Conengmo commented 11 months ago

Same like in https://github.com/python-visualization/folium/pull/1817, remove the environment saved as class instance attribute on Element.

I suspect this was added early on because they expected we would load templates from the filesystem. Instead we now make templates dynamically from strings. So there's no need to store this on class instances. If somebody still wants to use it, we still have ENV as module variable available.

Conengmo commented 10 months ago

Almost forgot about this one :p thanks for the review Martin!