search

python-visualization / branca

This library is a spinoff from folium, that would host the non-map-specific features.
https://python-visualization.github.io/branca/
MIT License
112 stars 64 forks source link

Cleanup Templates strings #4

Closed BibMartin closed 8 years ago

BibMartin commented 8 years ago

Do not merge, work in progress...

BibMartin commented 8 years ago

Ok @ocefpaf, this is ready for review (I guess I shall stop self-merge on branca). This PR works in combination with https://github.com/python-visualization/folium/pull/373. But I need this PR to be merge first, so that I can drop commit https://github.com/BibMartin/folium/commit/acb059c2f4fb655e5d64bdba1440e50486b845f2 and let folium point to python-visulization/branca.

BibMartin commented 8 years ago

@ocefpaf If you have time to review and merge this PR, I'll make the v0.1.0 release based on this.

btw: can you remind me what needs to be done for release ? As far as I remember it requires:

ocefpaf commented 8 years ago

I don't have merge rights here.

Creating a branch v0.1.0

That part is easy :wink:

Putting a tag v0.1.0 at the branch start

I usually using GutHub web interface to create the release from that branch. That generates the tag automatically.

Putting things into pypi (I don't know how to do that, nor have the rights I think).

Unless the name branca is taken you have to create a PyPI package. I can do that and add you as administrator of the package.

PS: Reviewing now...

ocefpaf commented 8 years ago

@BibMartin I need to get more familiar with the code to be helpful here, but everything look good to me. I made a few minor comments.

BibMartin commented 8 years ago

@BibMartin I need to get more familiar with the code to be helpful here, but everything look good to me. I made a few minor comments.

Too late to adapt code to your comments. I'll make another small PR in the future ; but we can release now.

BibMartin commented 8 years ago

Thanks for fast and efficient review !

ocefpaf commented 8 years ago

Too late to adapt code to your comments.

Oops. I did not consider my review worth of the changes. Anyways, I plan to load the notebooks here, play with them, and then send a PR with proper comments/reviews.