fix caption being propagated in scale funtions

python-visualization / branca

This library is a spinoff from folium, that would host the non-map-specific features.

https://python-visualization.github.io/branca/

MIT License

112 stars 64 forks source link

fix caption being propagated in scale funtions #62

Closed BalthasarSchachtner closed 5 years ago

BalthasarSchachtner commented 5 years ago

Hi everyone, small fix: If you use the caption keyword in LinearColormap or StepColormap and apply afterwards scale, the caption is reset to empty string. Fix propagates the caption. For the problem see also the screenshot, the second caption does not appear. I would like to share the ipython notebook, but unfortunately I cannot attach it here, feel free to contact me directly.

Screenshot_2019-07-12 Colormaps

ocefpaf commented 5 years ago

The CI failures here are unrelated to this PR. I'll merge this as is and fix the CIs later. Thanks @BalthasarSchachtner!

BalthasarSchachtner commented 5 years ago

Thanks