search

python-visualization / branca

This library is a spinoff from folium, that would host the non-map-specific features.
https://python-visualization.github.io/branca/
MIT License
118 stars 66 forks source link

Removed misleading info in docstring #84

Closed simoubuntu closed 3 years ago

simoubuntu commented 3 years ago

In _parse_size there are only two cases: if input is float or int -> consider it as pixel measure if input is string -> parse it as percentage. If '300px' is set as parameter, the exception "ValueError: Cannot parse value '300px' as '%'" is raised.

Conengmo commented 3 years ago

Thanks! That was indeed wrong. I considered changing the parsing function, since I don't understand why we would be so restrictive in the first place. But maybe there's a good reason for it, I don't know.

simoubuntu commented 3 years ago

I considered it too, but I'm not so expert. Maybe in the future I will check again. Thank you!