dash-separated key will no longer be supported

[Conengmo]

Hi @atupone, can you clarify what package you are talking about, that will no longer support this dash-separated key?

[atupone]

Setuptools

Il ven 30 lug 2021, 22:06 Frank @.***> ha scritto:

Hi @atupone https://github.com/atupone, can you clarify what package you are talking about, that will no longer support this dash-separated key?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/python-visualization/branca/pull/98#issuecomment-890126459, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWTKG6MJVLV3WOOV6QS4NTT2MA5XANCNFSM5BJASMDQ .

[martinfleis]

xref https://github.com/pypa/setuptools/pull/2588

[Conengmo]

It seems that setuptools does recognize the description-file syntax, though the table says they themselves use a different syntax: https://setuptools.readthedocs.io/en/latest/userguide/declarative_config.html#compatibility-with-other-tools. I don't see description_file anywhere here, so I'm not sure if changing the dash for an underscore is the solution.

I don't even know if we still use this config, if changing this is even relevant.

There are more keys with dashes in them in this file. Do we have to change those as well?

Will changing dashes to underscores in this file break anything else?

@ocefpaf can you weigh in? You know more about this than I do

[Conengmo]

description-file or description_file are both not supported keys: https://setuptools.pypa.io/en/latest/userguide/declarative_config.html. Instead we should use long_description. See this Stackoverflow answer: https://stackoverflow.com/questions/60084128/does-description-file-in-setup-cfg-section-metadata-have-any-effect.

I'll update the PR to use long_description. Also, license_file should be license_files.

[Conengmo]

Continued here: https://github.com/python-visualization/branca/pull/116