Closember participation

[ocefpaf]

@Conengmo what do you think? Take a look at https://closember.org/ and let me know.

I believe there are some stale PRs, already resolved or no longer relevant issues that could use a clean-up!

[Conengmo]

Love it! We could definitely use some cleaning up, and merging good PRs we got waiting. Setting a goal for this month sounds like a good idea to gain some momentum. And fortunately I have some time to spend as well.

Few things we could focus on:

• Get through the backlog of PRs
• Close more issues
• Work on open issues

For PRs:

• Review PR's that look promising.
• Close stale PR's that don't offer much value. (Shortly explain why and what would be avenues for reopening)

I'm not sure about closing old issues. I think many of them are still valid, it's more that what they propose is not getting done. Maybe it's a good idea to close them since they didn't get traction, and offer anybody that reads the closed issue to reopen if they are actually able to work on it.

To be done: a shortlist of what would be good to have done first.

[Conengmo]

How users can help

Let us know in this issue thread!

Close your own stale issues or PRs

If you have an open issue or PR on this repo that you don't support anymore, you can close it yourself. Please include a closing message with a (one sentence) explanation.

Test open PR's

Look at the open PR's, pick one you are interested in, pull that code and test any or all of the following:

• first verify the problem the PR solves
• test the PR solves the problem
• identify possible side effects or downsides
• identify if the implementation could/should be better

Then include your test report in the PR! The goal is for us maintainers to able to merge or close the PR with less effort.

Help triage issues

We have many open issues without any replies yet. You could help by flagging issues that can be closed:

• they may be a duplicate of an existing issue
• they may ask for a feature that already exists
• they may contain a simple question that can easily be answered by pointing to the documentation or an example

[Conengmo]

Ambitions

• [x] Close all open PRs from before November on folium
• [x] Close all open PRs from before November on branca
• [x] Get to top of the 'Closed issues/PRs' list on https://closember.org.
• [x] Run black and isort and such on folium at the end of November.
• [x] Run black and isort and such on branca at the end of November.
• [x] Triage and label all open issues, closing all stale questions, keeping enhancement proposals (within reason).
• [x] Be at the top of the 'Closed issues/PRs' list on https://closember.org when November ends.

[Conengmo]

Look at that, no open issues or PRs on branca 🎉

[Conengmo]

Branca got a mention from the closember twitter account: https://nitter.net/ClosemberDev/status/1589522298742128641#m

[Conengmo]

I also liked this message, congratulating us with reaching zero on branca and 27 closed PRs on folium: https://nitter.net/ClosemberDev/status/1590774786745307136#m

[ocefpaf]

We should schedule a call for a virtual toast to celebrate Closember ;-p

[Conengmo]

We have the most closed PRs on the board, which is a nice reflection of the amount of work we did!

https://nitter.net/ClosemberDev/status/1592651419059789824#m

[ocefpaf]

which is a nice reflection of the amount of work we did!

You mean you did! I'm pretty much watching from the sidelines. Thanks for the effort you put into this!! We need a new release soon to ship all the new features and bugfixes.

[Conengmo]

Well we made the top of the list, so we can cross off that goal as well. Let's see how long we can stay there.

[ocefpaf]

@Carreau is the mastermind behind closember. I'm pretty sure he has a "mission accomplished" feeling right now.

[Carreau]

😍 If you loved it and it put you at ease, then you are the winner ! I likely need to tweak the code of the website to only count on the third closeboard projects that actually had opened PRs so that you are at the top of two closeboard.

If you don't mind once this is over I'd love to send you some questions and write a blog post on how you liked focusing on finishing things.

[Conengmo]

Thanks for organizing this @Carreau! It's much appreciated.

If you don't mind once this is over I'd love to send you some questions and write a blog post on how you liked focusing on finishing things.

Sure thing, I'd be happy to help!

[Conengmo]

Only 7 unlabeled open issues remaining! https://github.com/python-visualization/folium/issues?q=is%3Aopen+is%3Aissue+no%3Alabel I'm confident we can resolve those before the month is over. We closed around 150 issues in the past few weeks :sweat_smile:

[Conengmo]

We got all unlabeled open issues! I'll tick off the goal to triage and label all open issues. Remaining open issues contain valid feature ideas/requests, still to be solved bugs and valid requests for better documentation in certain areas.

[Conengmo]

Looks like there is no more low hanging fruit left at the moment. I'll go ahead and compile a changelog for the upcoming release. It's going to be a big one!

[Conengmo]

I added the changelog for the upcoming release: https://github.com/python-visualization/folium/blob/main/CHANGES.txt. Looks like we are good to go with this huge release! @ocefpaf could you bake a 0.14.0 release? I'll not merge new stuff until then.

[Conengmo]

It's still some hours for this last day of Closember, also depending on your timezone, but since I'm busy coming days I'm going to call it now already and say folium made the top of the closeboard:

So I'll go ahead and mark that final goal as well :) Feels really good to have the project in a much better state now.

[ocefpaf]

I'm freezing this here for posterity:

[Conengmo]

I'm freezing this here for posterity:

That looks great, thanks for sharing!