search

python-visualization / folium

Python Data. Leaflet.js Maps.
https://python-visualization.github.io/folium/
MIT License
6.72k stars 2.21k forks source link

Drop Bootstrap 3 but keep glyphicons #1914

Closed Conengmo closed 1 month ago

Conengmo commented 1 month ago

In https://github.com/python-visualization/folium/pull/1650 we transitioned from Bootstrap 3 to 5. We also had to keep Bootstrap 3 for the Glyphicon icons in the AwesomeMarkers.

Turns out there's also a hosted css file with only the css necessary for the glyphicons, not the entirety of Bootstrap 3. See https://stackoverflow.com/a/18225474/4082914 under "If you want to use the Glyphicons separately". Use that file instead.

Closes https://github.com/python-visualization/folium/issues/1908.

Conengmo commented 1 month ago

Thanks Hans for the review!