fix __geo_interface__ styling

python-visualization / folium

Python Data. Leaflet.js Maps.

https://python-visualization.github.io/folium/

MIT License

6.94k stars 2.23k forks source link

fix __geo_interface__ styling #1935

Closed ocefpaf closed 7 months ago

ocefpaf commented 7 months ago

Closes https://github.com/python-visualization/folium/issues/1932.

[X] Fixes the geopandas (or any __geo_interface__ object) styling regression.
[x] Amend the docs with a CAVEAT regarding Late Binding Closures when using style_function in a loop.

ocefpaf commented 7 months ago

This one fixes the geopandas issue but I need to amend the docs for the pitfalls in the loop case and I also need to check if my simplistic solution is good enough and doesn't clash with the current styling options we have.

Screenshot from 2024-04-19 19-28-18

ocefpaf commented 7 months ago

@Conengmo and @hansthen I'm planning on a new release but I guess we should also try to get https://github.com/python-visualization/folium/pull/1903 (and maybe others) in before that?