Docs are failing b/c altair is not py313 ready yet

python-visualization / folium

Python Data. Leaflet.js Maps.

https://python-visualization.github.io/folium/

MIT License

6.94k stars 2.23k forks source link

Docs are failing b/c altair is not py313 ready yet #2016

Closed ocefpaf closed 1 month ago

ocefpaf commented 1 month ago

xref.: https://github.com/vega/altair/issues/3620

Conengmo commented 1 month ago

Weird that the workflow didn't fail on the py313 PR https://github.com/python-visualization/folium/pull/2013...

Conengmo commented 1 month ago

I'll build the latest release docs manually, since we now passed that window.

Conengmo commented 1 month ago

I tried to make a temporary fix https://github.com/python-visualization/folium/pull/2017

ocefpaf commented 1 month ago

Weird that the workflow didn't fail on the py313 PR #2013...

We are pinning to an exact Python in the docs, which is fine, but the "python=3" means that sometimes we can build them with 3.12 if the solver feels like it 😄

Conengmo commented 1 month ago

ooh okay, so we should actually pin to an exact version there, that's more robust!

ocefpaf commented 1 month ago

ooh okay, so we should actually pin to an exact version there, that's more robust!

It should not matter in an ideal world but... Yeah, probably safer b/c we do depend on dozens of libs in our docs and demos.