search

python-visualization / folium

Python Data. Leaflet.js Maps.
https://python-visualization.github.io/folium/
MIT License
6.9k stars 2.22k forks source link

Plugins ideas for a sprint #735

Closed ocefpaf closed 5 years ago

ocefpaf commented 7 years ago
ghandic commented 7 years ago

Just looked at https://github.com/albburtsev/Leaflet.geojsonCSS - looks similar to what I have just submitted for a pull request but in the TimestampedGeoJson Plugin. Happy to implement this wider using their layout

ocefpaf commented 7 years ago

@ghandic That would be nice! Do you want to submit in the same PR or do you want to close that and send a new one?

ghandic commented 7 years ago

I’ll do it in another pull request, also looking into the leaflet-search, I’m trying to maintain short branches so will do these in separate PR’s

Sent from my iPhone

On 13 Oct 2017, at 17:49, Filipe notifications@github.com<mailto:notifications@github.com> wrote:

@ghandichttps://github.com/ghandic That would be nice! Do you want to submit in the same PR or do you want to close that and send a new one?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/python-visualization/folium/issues/735#issuecomment-336506907, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AWaWQSjXOJt2dRufQwijlkdrfjwjVQqCks5sr5SdgaJpZM4PkL9G.

ocefpaf commented 7 years ago

Awesome!

ghandic commented 7 years ago

I'm going to look into https://github.com/albburtsev/Leaflet.geojsonCSS this week, should this be implemented as standard rather than a plugin?

I have implemented this in 'features.py' could deprecate the old GeoJson in favour of the GeoJsonCss? Both are in there for now

ghandic commented 7 years ago

Thinking of incorporating BeafutifyMarker, ExtraMarkers into the Marker class rather than having two new classes.

I feel like I'm putting in too many PR! Haha, what do you think @ocefpaf

ocefpaf commented 7 years ago

There is no such a thing as too many PRs ;-p

I'm away from office though and I'll only be able to review than next week.

prusswan commented 6 years ago

What is needed to integrate plugins into folium? I wish it could work with arbitrary plugins (something like Plunker etc)

ocefpaf commented 5 years ago

Closing this for now. The list of plugin is still interesting but many of those can be implemented as external plugins.