search

python-wheel-build / fromager

Build your own wheels
https://pypi.org/project/fromager/
Apache License 2.0
3 stars 9 forks source link

Restoring mergify_linter in CI #198

Closed rd4398 closed 1 month ago

rd4398 commented 1 month ago

This PR is for the issue: https://github.com/python-wheel-build/fromager/issues/172

I am new to writing workflows, CI and GitHub actions so not sure whether what I have done in this PR is correct. Please let me know if any changes are required

shubhbapna commented 1 month ago

Looks like the yaml module is not installed: https://github.com/python-wheel-build/fromager/actions/runs/9996065530/job/27629569454?pr=198#step:5:15.

You will have to install it in the install dependency step. I also don't think you need tox unless you are adding a new target to run the mergify linter

rd4398 commented 1 month ago

Oh okay! Let me add that step

dhellmann commented 1 month ago

https://github.com/python-wheel-build/fromager/pull/62/files shows how this was done the first time around.

Including it in tox.ini means a developer can run the same test locally very easily.

rd4398 commented 1 month ago

Okay, I am a bit confused... tox.ini already has this (https://github.com/python-wheel-build/fromager/pull/62/files ) included in main branch. Is there any other way to restore or am I missing something?

dhellmann commented 1 month ago

It looks like maybe a merge conflict was resolved poorly.

I see the linter invoked here, in the pkglint section of tox.ini https://github.com/python-wheel-build/fromager/blob/main/tox.ini#L67

I expected that to show up in the linter section.

rd4398 commented 1 month ago

okay, I will move it there