python-wheel-build / fromager

Build your own wheels
https://fromager.readthedocs.io/en/latest/
Apache License 2.0
4 stars 9 forks source link

Add package-version-specific changelog to settings #317

Closed shubhbapna closed 1 month ago

shubhbapna commented 1 month ago

Agreed upon template:

torch:
  changelog:
    "2.3.1":
      - rebuild for xyz
shubhbapna commented 1 month ago

@dhellmann @tiran regarding the the template for this changelog should we have something like this if we know that one change can affect many versions:

torch:
   changelog:
        - name: rebuild xyz
          affected_versions: ["2.3.1", "2.3.2"]

or


torch:
   changelog:
        rebuild xyz:
               - "2.3.1"
               - "2.3.2"
dhellmann commented 1 month ago

Keeping them separate lists makes it easier to scan the list as a human reader.

How likely do you think it will be that we have an update that affects multiple versions?

shubhbapna commented 1 month ago

Okay, yeah the likeliness is low that it affects multiple versions at the same time (especially given that we have been trying to reduce the number of versions we build for a package in the same bootstrap)