FAIL: test_single_namespace_single_path_leaf_names

[danstender]

Hi, we've got a test failure here in the Debian package:

======================================================================
FAIL: test_single_namespace_single_path_leaf_names (test.test_exempi.TestIteration)
Get just leaf names from a single path, single namespace.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/<<BUILDDIR>>/python-xmp-toolkit-2.0.1+git20140309.5437b0a/test/test_exempi.py", line 546, in test_single_namespace_single_path_leaf_names
    self.assertEqual(schemas, [NS_DC, NS_DC, NS_DC])
AssertionError: Lists differ: [u'http://purl.org/dc/elements... != ['http://purl.org/dc/elements/...

First differing element 1:
u''
'http://purl.org/dc/elements/1.1/'

- [u'http://purl.org/dc/elements/1.1/',
?  -

+ ['http://purl.org/dc/elements/1.1/',
-  u'',
-  u'http://www.w3.org/XML/1998/namespace']
+  'http://purl.org/dc/elements/1.1/',
+  'http://purl.org/dc/elements/1.1/']

----------------------------------------------------------------------
Ran 73 tests in 1.150s

FAILED (failures=1, skipped=3)

Buildlog: http://aws-logs.debian.net/2017/01/11/python-xmp-toolkit_2.0.1+git20140309.5437b0a-3_unstable.log DS

[quintusdias]

Looks like a difference between exempi 2.3 and 2.4. Have to think a bit about what the best way to approach this would be.

On Thu, Jan 19, 2017 at 4:38 PM, Daniel Stender notifications@github.com wrote:

Hi, we've got a test failure here in the Debian package:

====================================================================== FAIL: test_single_namespace_single_path_leaf_names (test.test_exempi.TestIteration) Get just leaf names from a single path, single namespace.

Traceback (most recent call last): File "/<>/python-xmp-toolkit-2.0.1+git20140309.5437b0a/test/test_exempi.py", line 546, in test_single_namespace_single_path_leaf_names self.assertEqual(schemas, [NS_DC, NS_DC, NS_DC]) AssertionError: Lists differ: [u'http://purl.org/dc/elements... != ['http://purl.org/dc/elements/...

First differing element 1: u'' 'http://purl.org/dc/elements/1.1/'

• [u'http://purl.org/dc/elements/1.1/', ? -

• ['http://purl.org/dc/elements/1.1/',

• u'',

• u'http://www.w3.org/XML/1998/namespace']

• 'http://purl.org/dc/elements/1.1/',

• 'http://purl.org/dc/elements/1.1/']

---

Ran 73 tests in 1.150s

FAILED (failures=1, skipped=3)

Buildlog: http://aws-logs.debian.net/2017/01/11/python-xmp-toolkit_ 2.0.1+git20140309.5437b0a-3_unstable.log DS

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/python-xmp-toolkit/python-xmp-toolkit/issues/67, or mute the thread https://github.com/notifications/unsubscribe-auth/ACokXsSUIxQrI1UOpPc8fI09C7WdyCNKks5rT9fMgaJpZM4Loovm .

-- John Evans

[hfiguiere]

In Exempi 2.4.0 it return the following schemas: ['http://purl.org/dc/elements/1.1/', '', 'http://www.w3.org/XML/1998/namespace'] which looks what I'd expect. I'll check the difference between 2.3.0 and 2.4.0: the Adobe SDK version changed. Bonus: I'll add that to the exempi test suite.

Exempi bug is https://bugs.freedesktop.org/show_bug.cgi?id=99480

[hfiguiere]

The change was introduced by Adobe in the "CS6" SDK. This is hfiguiere/exempi@81a4c6bc , in XMPCore/source/XMPIterator.cpp:573 which happened between 2.3.0 and 2.4.0

• This actually fix a bug. (I found the expected values before to not be the right one)
• This also (IMHO) break API/ABI since we no longer get the same result. Not sure what's the best approach, and I think fixing the buggy behaviour is more important.

[hfiguiere]

I'll submit a fix to the test suite.

[danstender]

Great job. Thank you very much! DS